Merged
Conversation
max-ipinfo
approved these changes
Jul 21, 2025
max-ipinfo
pushed a commit
that referenced
this pull request
Jul 21, 2025
* Fix tests not making requests * Fix linting issues * Add linting and remove unnecessary ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION env var in CI * Add support for Lite API * Update README.md * Fix workflow
max-ipinfo
pushed a commit
that referenced
this pull request
Jul 21, 2025
* Fix tests not making requests * Fix linting issues * Add linting and remove unnecessary ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION env var in CI * Add support for Lite API * Update README.md * Fix workflow
max-ipinfo
pushed a commit
that referenced
this pull request
Jul 21, 2025
* Fix tests not making requests * Fix linting issues * Add linting and remove unnecessary ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION env var in CI * Add support for Lite API * Update README.md * Fix workflow
max-ipinfo
deleted the
silvano/eng-293-add-lite-api-support-to-ipinfoerlang
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usual approach as other libraries.
I had to change the existing tests as they were using a local mocked server thus stopping me from testing the actual new endpoints.
I also added more versions in the CI workflow to add linting and removed some unnecessary stuff like the
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSIONenv var.Because of linting I had to change some code in the existing implementation to fix the errors.