Add car put-block command#629
Conversation
willscott
left a comment
There was a problem hiding this comment.
looks generally reasonable. a couple comments to think about, but no strongly held objection to this
- write counterpart to get-block - can set root on first block write (optional), not on appends (API/car standard limitation?)
|
ok, I've addressed the concerns:
|
willscott
left a comment
There was a problem hiding this comment.
Looks great. since we don't have CI tests over this i want to pull and confirm the test script locally, but will plan to merge later today or tomorrow
|
the remaining nit is that the original commit should have been titled "Add |
Co-authored-by: Rod Vagg <rod@vagg.org>
|
Thanks again! |
BTW I'm not sure what you mean by this, I see my tests running in CI? https://github.com/ipld/go-car/actions/runs/18562918723/job/52916178584#step:13:5723 anyway thanks for merging, will be nice to be able to go install without replaces :) |
this is handy if you need to package up some blocks from an IPFS node (among other cases);
ipfs dag exportwants to walk the whole DAG, which doesn't work if you only need a shallow traversaluse like:
I tried to match the semantics to how the other write commands work