This repository was archived by the owner on Aug 11, 2021. It is now read-only.
Merged
Conversation
vmx
approved these changes
May 2, 2018
Member
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
Thanks for making all these changes. I generally prefer having a clean Git history, so that you can later see what was going on. If all those commits are squashed into one it mixes a lot of things.
README updates and dependency updates shouldn't be in the same commit, as it makes reverting things hard/bad if a dependency breaks things.
Anyway as there's a lots of things going, feel free to merge it as it currently is :)
Member
Author
|
@vmx understood and agree with that best practice. Let's make sure to encourage that pattern always. Merging here for the sake of not spending extra time with this PR. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ipfs/community#301