Skip to content

Add requestsRoot to t8n output for Prague#1018

Merged
gumb0 merged 1 commit into
masterfrom
t8n-requests-root
Sep 18, 2024
Merged

Add requestsRoot to t8n output for Prague#1018
gumb0 merged 1 commit into
masterfrom
t8n-requests-root

Conversation

@gumb0

@gumb0 gumb0 commented Sep 18, 2024

Copy link
Copy Markdown
Member

Pulled out of #961

This is related to https://eips.ethereum.org/EIPS/eip-7685 and required for filling EEST for Prague.

Comment thread test/t8n/t8n.cpp
}
if (rev >= EVMC_PRAGUE)
{
j_result["requestsRoot"] = hex0x(state::EMPTY_MPT_HASH);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment as in the PR.

@codecov

codecov Bot commented Sep 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.08%. Comparing base (0453324) to head (aab8757).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
test/t8n/t8n.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
- Coverage   94.08%   94.08%   -0.01%     
==========================================
  Files         147      147              
  Lines       15746    15748       +2     
==========================================
+ Hits        14815    14816       +1     
- Misses        931      932       +1     
Flag Coverage Δ
eof_execution_spec_tests 17.37% <0.00%> (-0.01%) ⬇️
ethereum_tests 27.44% <0.00%> (-0.01%) ⬇️
ethereum_tests_silkpre 19.27% <0.00%> (-0.01%) ⬇️
execution_spec_tests 19.91% <0.00%> (-0.01%) ⬇️
unittests 88.89% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/t8n/t8n.cpp 86.39% <50.00%> (-0.51%) ⬇️

@gumb0 gumb0 merged commit 7c6a3ce into master Sep 18, 2024
@gumb0 gumb0 deleted the t8n-requests-root branch September 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants