Skip to content

test: Support chain_id in loading multi-transaction state tests#1023

Merged
chfast merged 1 commit into
masterfrom
test/statetest-loader-chainid
Sep 23, 2024
Merged

test: Support chain_id in loading multi-transaction state tests#1023
chfast merged 1 commit into
masterfrom
test/statetest-loader-chainid

Conversation

@gumb0
Copy link
Copy Markdown
Member

@gumb0 gumb0 commented Sep 20, 2024

Also set default chain_id to 1 - see confirmation that this is expected behavior https://discord.com/channels/595666850260713488/753271902520213625/1280839101687533619

Pulled out of #961, required for 7702 tests.

@gumb0 gumb0 marked this pull request as ready for review September 20, 2024 13:15
@gumb0 gumb0 requested review from chfast and pdobacz September 20, 2024 13:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.19%. Comparing base (eaecdd5) to head (f483c91).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1023   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         149      149           
  Lines       15887    15888    +1     
=======================================
+ Hits        14964    14965    +1     
  Misses        923      923           
Flag Coverage Δ
eof_execution_spec_tests 17.25% <60.00%> (+<0.01%) ⬆️
ethereum_tests 27.33% <60.00%> (+<0.01%) ⬆️
ethereum_tests_silkpre 19.13% <40.00%> (+0.01%) ⬆️
execution_spec_tests 20.42% <60.00%> (+<0.01%) ⬆️
unittests 88.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/statetest/statetest_loader.cpp 96.85% <100.00%> (+0.01%) ⬆️
test/unittests/statetest_loader_test.cpp 100.00% <100.00%> (ø)
test/unittests/statetest_loader_tx_test.cpp 100.00% <100.00%> (ø)

@chfast chfast changed the title Support chain_id in loading multi-transaction state tests test: Support chain_id in loading multi-transaction state tests Sep 23, 2024
@chfast chfast added the tests Testing infrastructure label Sep 23, 2024
@chfast chfast force-pushed the test/statetest-loader-chainid branch from 7f2c594 to f483c91 Compare September 23, 2024 08:33
@chfast chfast merged commit 593cc95 into master Sep 23, 2024
@chfast chfast deleted the test/statetest-loader-chainid branch September 23, 2024 08:50
hanzo-dev pushed a commit to luxcpp/cevm that referenced this pull request Apr 26, 2026
…lon#1023)

Also set default `chain_id` to 1 - see confirmation that this is
expected behavior
https://discord.com/channels/595666850260713488/753271902520213625/1280839101687533619

Pulled out of ipsilon#961, required for 7702 tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants