eof: Change kind_data from 0x04 to 0xff

[pdobacz]

Align with eof-devnet-1 changes ipsilon/eof#173. Goes in hand with ethereum/execution-spec-tests#1339

[codecov]

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.90%. Comparing base (065a411) to head (426f643).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
lib/evmone/eof.cpp	88.88%	1 Missing ⚠️
test/unittests/eof_test.cpp	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
- Coverage   94.91%   94.90%   -0.02%     
==========================================
  Files         171      171              
  Lines       19640    19648       +8     
==========================================
+ Hits        18642    18646       +4     
- Misses        998     1002       +4     

Flag	Coverage Δ
eof_execution_spec_tests	?
ethereum_tests	22.39% <0.00%> (-0.01%)	⬇️
ethereum_tests_silkpre	17.90% <0.00%> (-0.01%)	⬇️
execution_spec_tests	19.59% <0.00%> (-0.01%)	⬇️
unittests	92.44% <97.14%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
test/unittests/eof_example_test.cpp	100.00% <100.00%> (ø)
test/unittests/eof_validation_test.cpp	99.40% <100.00%> (ø)
test/unittests/evm_eof_function_test.cpp	98.80% <ø> (ø)
test/unittests/evm_eof_test.cpp	100.00% <100.00%> (ø)
test/utils/bytecode.hpp	97.39% <100.00%> (ø)
lib/evmone/eof.cpp	85.93% <88.88%> (-0.33%)	⬇️
test/unittests/eof_test.cpp	94.54% <80.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pdobacz]

note that this is resolved and the TODO removed in a subsequent PR

[pdobacz]

While the tests are failing, I would prefer to force merge without silencing them. It is somewhat reassuring that at least some tests pass, which we can just eyeball when merging. If we silence the tests, we'll lose that possibility. But I can also silence tests if needed.

Doing an interim EEST release in the ipsilon fork would be an option, but unfortunately, this seems to not work anymore. Final alternative is to make a proper EEST release like v3.0.0-rc1, filling it with an off-of-a-branch evmone. probably tidiest but most legwork.

Maybe that is the way to go tho :/

[pdobacz]

Merging to move fast. It fills for me locally, if I arrange the evmone - EEST branches to match