Skip to content

Remove workarounds for old compiler and dependencies #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chfast merged 1 commit into from
May 16, 2025
Merged

Remove workarounds for old compiler and dependencies #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/state/mpt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ class Path
/// The MPT Node.
///
/// The implementation is based on StackTrie from go-ethereum.
// TODO(clang-tidy-17): bug https://github.com/llvm/llvm-project/issues/50006
// NOLINTNEXTLINE(bugprone-reserved-identifier)
class MPTNode
{
static constexpr size_t num_children = 16;
Expand Down
7 changes: 1 addition & 6 deletions test/state/precompiles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,12 +649,7 @@ inline constexpr std::array<PrecompileTraits, NumPrecompiles> traits{{

bool is_precompile(evmc_revision rev, const evmc::address& addr) noexcept
{
// Define compile-time constant,
// TODO(clang18): workaround for Clang Analyzer bug, fixed in clang 18.
// https://github.com/llvm/llvm-project/issues/59493.
static constexpr evmc::address address_boundary{stdx::to_underlying(PrecompileId::latest)};

if (evmc::is_zero(addr) || addr > address_boundary)
if (evmc::is_zero(addr) || addr > evmc::address{stdx::to_underlying(PrecompileId::latest)})
return false;

const auto id = addr.bytes[19];
Expand Down
2 changes: 1 addition & 1 deletion test/state/state.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ StateDiff State::build_diff(evmc_revision rev) const
// Unconditionally report nonce and balance as modified.
// TODO: We don't have information if the balance/nonce has actually changed.
// One option is to just keep the original values. This may be handy for RPC.
// TODO(clang): In old Clang emplace_back without Account doesn't compile.
// TODO(clang): In AppleClang 15 emplace_back without StateDiff::Entry doesn't compile.
// NOLINTNEXTLINE(modernize-use-emplace)
auto& a = diff.modified_accounts.emplace_back(StateDiff::Entry{addr, m.nonce, m.balance});

Expand Down
6 changes: 0 additions & 6 deletions test/unittests/precompiles_kzg_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ using namespace evmone::crypto;

namespace
{
// TODO(intx): Add ""_u384.
consteval auto operator""_u384(const char* s)
{
return intx::from_string<intx::uint384>(s);
}

constexpr auto G1_GENERATOR_X =
0x17F1D3A73197D7942695638C4FA9AC0FC3688C4F9774B905A14E3A3F171BAC586C55E83FF97A1AEFFB3AF00ADB22C6BB_u384;
constexpr std::byte ZERO32[32]{};
Expand Down