tracing: Keep copy of output path in InstructionCounter#1554
Merged
Conversation
Previously used string_view for output path causes lifetime issues for users: the tracer outputs to file during destruction.
There was a problem hiding this comment.
Pull request overview
This PR fixes a lifetime hazard in InstructionCounter tracing by storing an owned copy of the output file path, ensuring the tracer can safely write its results during destruction.
Changes:
- Replace
std::string_viewoutput path storage with an owningstd::string. - Simplify
std::ofstreamconstruction to use the stored path directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| std::stack<bytes_view> m_codes; | ||
| std::array<unsigned, 256> m_counters{}; | ||
| std::string_view m_out_file_path; | ||
| std::string m_out_file_path; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 163 163
Lines 14455 14455
Branches 3383 3383
=======================================
Hits 14018 14018
Misses 307 307
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously used string_view for output path causes lifetime issues for users: the tracer outputs to file during destruction.