Replies: 2 comments
We never got around to enforcing that.
Nope. we were never out-of-drift ;))
Those would be nice to fix.
Wow, it's amazing how much (inconsistent) code we generated ;)) Let's say we go for rearranging this set of deck chairs (as in "the activity is as useful as rearranging deck chairs on Titanic"), are there any single/double quote preferences @jbemmel @DanPartelly |
|
I prefer double quotes; if for nothing else, it's easy to type on any keyboard. You may want to interrogate based-pyright as well, see what issues it yields. But lemme say this. Ruff has one opinion; MyPy begs to differ. Pyright does things one way. Based-pyright, another way. Yaml formatters, it's probably anyone's guess. I used vim without any py/yaml addons for my first contributions to Netlab. It worked better than the default environments of VS Code or Zed. I used Zed for last. It's fast. Way lower latency then VsCode. Zed uses based-pyright by default, and finds shitloads of issues in Netlab. By default, Zed's YAML converter will convert to double quotes where required and use a more compact format for some constructs, for example modules: [ aaa bbb ] (Netlab style) is automatically converted to modules: [aaa, bbb] (this is the style I personally prefer). Had to disable it for now, or else the diffs for any yaml commit would be huge. |
Uh oh!
There was an error while loading. Please reload this page.
I noticed that the AGENTS.md and saw use of
ruff format netsimSeems we have drifted or we want to change some settings?
241 files would be reformatted, 11 files already formattedFair bit seems to be for double vs single quotes..
Then missing missing space after a comma.
The unified diff it generated in total went for 59k lines (for prefer double quotes) or 56k (for prefer single quotes)
All reactions