bgp.advertise on VLANs

[jbemmel]

I am confused by this:

netlab/tests/errors/vlan-invalid-attr.yml

Line 17 in bf7af6f

bgp.advertise: True

Its presence in that test suggests an intention to disallow its use - but there is no error, and a topology with that attribute will happily add a network statement to announce the prefix

Neither the VLAN tests nor the BGP tests have an example that combines BGP with VLANs - do we want to document this?

[ipspace]

I am confused

Hello, Confused 😉

Its presence in that test suggests an intention to disallow its use - but there is no error, and a topology with that attribute will happily add a network statement to announce the prefix

How about: we have a few attributes that work (for example, ospf.area and bgp.advertise) and a few that do not: ospf.something, which is clearly wrong, and bgp.local_as, which is an interface, not a link attribute.

Neither the VLAN tests nor the BGP tests have an example that combines BGP with VLANs - do we want to document this?

Do you also want to provide examples of everything else that works on VLANs? For example, how about IS-IS circuit type on VLANs?