intf.vlan.native not always set

[jbemmel]

netlab/netsim/modules/vlan.py

Line 307 in 5077bcc

elif not intf.vlan.native in node_trunk: # ... native VLAN not in trunk, that's not valid

should be

node_native = get_effective_module_attribute('vlan.native',intf=intf,link=link)
if node_native:                                         # Does this node use native VLAN?
  if not node_trunk:                                    # ... no trunk data for this node, cannot use native VLAN
    log.error(
      f'Node {intf.node} is using native VLAN without VLAN trunk\n... {link}',
      log.IncorrectValue,
      'vlan')
  elif node_native not in node_trunk:                   # ... native VLAN not in trunk, that's not valid

in case the native vlan is set on the trunk, but not on the interface

[ipspace]

Test case?

[jbemmel]

---
module: [ vlan ]

groups:
  _auto_create: True
  nodes:
    members: [ n1, n2 ]

vlans:
  v1:

links:
- n1:
    vlan.trunk:
      v1:
        vlan.mode: route
  n2:
  vlan.trunk: [ v1 ]
  vlan.native: v1

File "/home/user/netlab/netsim/modules/vlan.py", line 1353, in link_pre_transform
if not validate_link_vlan_attributes(link,v_attr,topology):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/netlab/netsim/modules/vlan.py", line 307, in validate_link_vlan_attributes
elif not intf.vlan.native in node_trunk: # ... native VLAN not in trunk, that's not valid
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "box/box.py", line 406, in box.box.Box.contains
File "box/box.py", line 386, in box.box.Box.hash
box.exceptions.BoxTypeError: unhashable type: "Box"

[ipspace]

Thank you. Will fix.