OS10: Disable ipv6 on loopback if not configured #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipspace
added a commit
that referenced
this pull request
Nov 7, 2024
This fix implements additional checks on main loopback IP addresses: it cannot be true/false (unnumbered/LLA loopbacks make no sense) and it cannot be int (node ID is used in that case). Prevents #1495 for good
ipspace
added a commit
that referenced
this pull request
Nov 7, 2024
This fix implements additional checks on main loopback IP addresses: it cannot be true/false (unnumbered/LLA loopbacks make no sense) and it cannot be int (node ID is used in that case). Prevents #1495 for good
ipspace
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, OS10 enables ipv6 on loopbacks and assigns a LLA. If the config says 'no ipv6', it should be disabled
Context: #1494