ospf.areas support for Dell OS10 & Cumulus NVUE#2364
Merged
ipspace merged 6 commits intoipspace:devfrom Jun 13, 2025
Merged
Conversation
Owner
|
Please rebase on dev. Also, as the last bit of that PR, I added the VRF checks to OSPFv2/OSPFv3 40-* test. |
jbemmel
force-pushed
the
dell_cumulus_ospf.areas
branch
from
d375e30 to
e85561d
Compare
Merged
jbemmel
force-pushed
the
dell_cumulus_ospf.areas
branch
from
932b53f to
e156ceb
Compare
ipspace
added a commit
that referenced
this pull request
Jun 13, 2025
ipspace
requested changes
Jun 13, 2025
Owner
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
You have to configure the NSSA summarization ranges or add a device quirk/caveat similar to what I did for EOS
Notes: * Dell OS10 does not support NSSA areas for OSPFv3 * Cumulus NVUE only supports OSPFv2 * Added a VRF test for OSPFv2
jbemmel
force-pushed
the
dell_cumulus_ospf.areas
branch
from
e156ceb to
669e602
Compare
jbemmel
force-pushed
the
dell_cumulus_ospf.areas
branch
from
bc83990 to
e637db1
Compare
ipspace
approved these changes
Jun 13, 2025
Owner
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
Looks good. Will run the tests and merge if they pass (with the obvious caveats). In the meantime, please rebase it, the change you made in ospf.areas.md removes Arista EOS line.
ipspace
added a commit
that referenced
this pull request
Jun 13, 2025
Owner
|
The integration tests are still failing in the expected places. Will add exceptions functionality to the validation test framework to deal with such stupidities. I hate having one more integration test just to deal with some vendors who can't get their shit in order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased after #2363 got merged
Notes:
Dell OS10 test fails due to lack of OSPF import support in vrfs (hardcoded
redistribute connected) - will fix in separate PR