Fix: Simplify SR-OS IS-IS template with 'configure_router' macro#2475
Merged
Fix: Simplify SR-OS IS-IS template with 'configure_router' macro#2475
Conversation
Most SR-OS configuration templates used 'declare_router' macro that would select the correct service configuration path based on interface data, leading to an awkward recreation of interface data in case we really wanted to configure a router, not an interface. This fix adds another layer of indirection (proving RFC 1925) in front of the 'declare_router' macro to make the routing protocol configuration templates a bit cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most SR-OS configuration templates used 'declare_router' macro that would select the correct service configuration path based on interface data, leading to an awkward recreation of interface data in case we really wanted to configure a router, not an interface.
This fix adds another layer of indirection (proving RFC 1925) in front of the 'declare_router' macro to make the routing protocol configuration templates a bit cleaner.