Fix: Check whether a tool was successfully started#2500
Merged
Conversation
This fix tracks the status of 'tool.up' command(s) as well as the output generated by Docker. If the output contains 'warning...platform' text, we might be dealing with a container started on an incompatible platform, in which case we wait a bit (because it will crash very soon), check its status, and report the outcome. The fix also adds better error reporting on tool start/stop failures and partial-success reporting. Closes #2456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix tracks the status of 'tool.up' command(s) as well as the output generated by Docker. If the output contains 'warning...platform' text, we might be dealing with a container started on an incompatible platform, in which case we wait a bit (because it will crash very soon), check its status, and report the outcome.
The fix also adds better error reporting on tool start/stop failures and partial-success reporting.
Closes #2456