Conversation
This fix uses a different name for suzieq container and parquet volume, allowing 'netlab up' to check whether the container has started (otherwise 'docker inspect' returns volume info when asked about the container). It also creates container without the 'auto remove' flag, so the user can inspect container logs in case of a fatal suzieq failure. The 'tool.down' command was modified accordingly to kill the container and then remove it.
Owner
Author
|
@ddutt -- adding you as a reviewer just in case you have time to look at it, but I'm guessing you have plenty of more important things to do, in which case I'll merge it in a day or two ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix uses a different name for suzieq container and parquet volume, allowing 'netlab up' to check whether the container has started (otherwise 'docker inspect' returns volume info when asked about the container).
It also creates container without the 'auto remove' flag, so the user can inspect container logs in case of a fatal suzieq failure.
The 'tool.down' command was modified accordingly to kill the container and then remove it.