Conversation
The 'netlab collect' command usually saves configuration files with the '.cfg' suffix (which can then be used in 'netlab up --reload' process). However, when building a multi-platform solution, it might be helpful to save the configuration files with a platform-specific suffix, for example 'eos.j2'. The '--suffix' parameter allows you to replace the standard 'cfg' suffix with something else As a few 'fetch-config' task lists used hardcoded '.cfg' suffix, most of them were either fixed to use the 'cfg_suffix' variable or (even better) set 'ansible_net_config' fact instead of creating the output file directly.
Owner
Author
|
I was sick-and-tired of renaming configuration files to platform-specific templates while writing the IS-IS labs, so I added another nerd knob to "netlab collect" and fixed a bit of technical debt while doing that. The FRR and SR Linux changes were tested; I hope I'm awake enough to do a find-and-replace on the CL tasklist ;) Adding reviewers just in case someone wants to look at this or comment. |
ssasso
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'netlab collect' command usually saves configuration files with the '.cfg' suffix (which can then be used in 'netlab up --reload' process). However, when building a multi-platform solution, it might be helpful to save the configuration files with a platform-specific suffix, for example 'eos.j2'. The '--suffix' parameter allows you to replace the standard 'cfg' suffix with something else
As a few 'fetch-config' task lists used hardcoded '.cfg' suffix, most of them were either fixed to use the 'cfg_suffix' variable or (even better) set 'ansible_net_config' fact instead of creating the output file directly.