Conversation
* Move the clab-specific port forwarding functions into the common provider module * Use the same functions to build clab- and libvirt ports list * Use the node libvirt.ports list when building forwarding ports in the Vagrantfile * Update libvirt documentation, adding the fun fact that vagrant-libvirt module sets up SSH port forwarding (not a NAT rule) * Add platform integration tests. The 'clab' test can be tested with a host script, I'm clueless about testing the SSH port forwarding Also: * Fix libvirt import into virtualbox provider module (the imported class name must start with an underscore) * Update the libvirt port forwarding transformation test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: