Conversation
The device/all groups are not allowed to have static members. It was thus impossible to set node attributes in a device/all group. This change adds dynamic calculation of group members for device/all groups. Making that work reliably required several other changes: * The 'set node device/module' function has to apply group values in two passes. It has to apply group.device in the first pass and group.module in the second pass because changing node.device could change group membership for a device group. * Computing members of a BGP autogroup now takes into account whether the global BGP module will be propagated into a node during the module initialization. * The 'should we propagate modules' check was refactored into a separate function because it's used during module initialization as well as during BGP autogroup creation. * node.device could be unspecified when BGP autogroup function calls the 'propagate_global_modules' check, but we know the only possible value that could be applied later on is the default device (because group-based devices were already set).
jbemmel
reviewed
Oct 14, 2025
jbemmel
reviewed
Oct 14, 2025
jbemmel
approved these changes
Oct 14, 2025
Collaborator
jbemmel
left a comment
jbemmel
left a comment
There was a problem hiding this comment.
Some minor considerations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device/all groups are not allowed to have static members. It was thus impossible to set node attributes in a device/all group.
This change adds dynamic calculation of group members for device/all groups. Making that work reliably required several other changes: