Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with IOL (IOS on Linux) BGP VRF configuration by adding explicit exit commands to properly terminate configuration contexts. The issue arises because the 'segment-routing srv6' command is valid in both VRF and global contexts, making explicit context termination necessary for startup configurations.
Changes:
- Added explicit
exitcommands in BGP VRF address-family and router bgp contexts - Modified Jinja2 template syntax to strip trailing whitespace after includes
- Added comment separators (
!) to improve configuration readability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| netsim/ansible/templates/vrf/ios.j2 | Added +%} to strip whitespace after BGP template inclusion and added comment separator after BGP and OSPF configuration blocks |
| netsim/ansible/templates/vrf/ios.bgp.j2 | Added exit commands to terminate address-family context (within neighbor loop) and router bgp context, plus final comment separator |
The BGP VRF configuration needs an explicit 'exit' when used with startup config due to 'segment-routing srv6' command being valid within VRF- and within global context.
ipspace
added a commit
that referenced
this pull request
Feb 11, 2026
ipspace
added a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BGP VRF configuration needs an explicit 'exit' when used with startup config due to 'segment-routing srv6' command being valid within VRF- and within global context.