Fix: Set explicit evpn.transport feature on VXLAN-only devices#3229
Merged
Fix: Set explicit evpn.transport feature on VXLAN-only devices#3229
Conversation
The EVPN module assumed that the devices that have no evpn.transport feature support VXLAN transport. Let's make that assumption explicit ;)
There was a problem hiding this comment.
Pull request overview
This PR makes EVPN transport support explicit by requiring features.evpn.transport to be present in device feature definitions, and by updating VXLAN-only devices to advertise transport: [vxlan] rather than relying on an implicit default.
Changes:
- Update EVPN transport validation to treat missing
features.evpn.transportas “no supported transports”. - Add
features.evpn.transport: [vxlan]to multiple VXLAN-only device definitions. - Explicitly set
features.evpn.transport: []forcrpdto indicate no supported EVPN transports.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| netsim/modules/evpn.py | Changes transport support check to no longer assume VXLAN when features.evpn.transport is missing. |
| netsim/devices/vyos.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/vptx.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/vjunos-switch.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/vjunos-router.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/sros.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/srlinux.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/nxos.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/frr.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/dellos10.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/cumulus_nvue.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/cumulus.yml | Declares EVPN transport support as VXLAN-only. |
| netsim/devices/crpd.yml | Explicitly declares no supported EVPN transports ([]). |
| netsim/devices/arubacx.yml | Declares EVPN transport support as VXLAN-only. |
ipspace
added a commit
that referenced
this pull request
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EVPN module assumed that the devices that have no evpn.transport feature support VXLAN transport. Let's make that assumption explicit ;)