Fix: Skip 'unused link module attributes' check for VLAN links#3382
Merged
Conversation
Implements the easy part of #3381
There was a problem hiding this comment.
Pull request overview
This PR reduces confusing “unused link module attribute” warnings on VLAN-enabled links by skipping early link/module-usage checks on links that carry VLAN information, aligning behavior with how VLAN members are resolved later in the pipeline.
Changes:
- Skip VRF “link uses vrf but no attached node uses vrf” validation on links that have a
vlanattribute. - Refactor “extra module attributes on link” warning logic into
check_extra_modules()and bypass it for VLAN links. - Update coverage expectations to reflect the removed warning for a VLAN scenario.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/coverage/expected/rt-vlan-anycast.yml | Removes expected _warning_extra_mod output for a VLAN-related link case. |
| netsim/modules/vrf.py | Skips VRF link-module usage validation for VLAN links to avoid premature warnings. |
| netsim/modules/init.py | Extracts extra-module detection into a helper and skips that check for VLAN links. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the easy part of #3381