Merged
Conversation
As of commit c3376f8 ("[efi] Drop to external TPL for calls to ConnectController()"), the veto mechanism will drop to TPL_APPLICATION for calls to DisconnectController(). Match this behaviour for calls to UnloadImage(), since that is likely to result in calls to DisconnectController(). For example, any EDK2 driver using NetLibDefaultUnload() as its unload handler will call DisconnectController() to disconnect itself from all handles. Signed-off-by: Michael Brown <mcb30@ipxe.org>
Commit cb95b5b ("[efi] Veto the Dhcp6Dxe driver on all platforms") vetoed the Dhcp6Dxe driver to work around the bug described at tianocore/edk2#10506 that results in EfiDhcp6Stop() getting stuck in a tight loop waiting for an event that will never occur. Since we now call UnloadImage() at TPL_APPLICATION, we no longer trigger the bug in Dhcp6Dxe, and so the veto may be removed. Signed-off-by: Michael Brown <mcb30@ipxe.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of commit c3376f8 ("[efi] Drop to external TPL for calls to ConnectController()"), the veto mechanism will drop to TPL_APPLICATION for calls to DisconnectController().
Match this behaviour for calls to UnloadImage(), since that is likely to result in calls to DisconnectController(). For example, any EDK2 driver using NetLibDefaultUnload() as its unload handler will call DisconnectController() to disconnect itself from all handles.
Commit cb95b5b ("[efi] Veto the Dhcp6Dxe driver on all platforms") vetoed the Dhcp6Dxe driver to work around the bug described at tianocore/edk2#10506 that results in EfiDhcp6Stop() getting stuck in a tight loop waiting for an event that will never occur.
Since we now call UnloadImage() at TPL_APPLICATION, we no longer trigger the bug in Dhcp6Dxe, and so the veto may be removed.
Fixes: #1358