Skip to content

Add stream parameter to getpass#201

Merged
takluyver merged 2 commits intoipython:masterfrom
Carreau:add-stream-parameter-to-getpass
Nov 3, 2016
Merged

Add stream parameter to getpass#201
takluyver merged 2 commits intoipython:masterfrom
Carreau:add-stream-parameter-to-getpass

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented Nov 2, 2016

'cause getpass.getpass takes stream as an argument.

@Carreau Carreau force-pushed the add-stream-parameter-to-getpass branch 2 times, most recently from 7c8bdeb to 241b2e8 Compare November 3, 2016 00:21
@minrk minrk added this to the 4.5.1 milestone Nov 3, 2016
@takluyver
Copy link
Member

======================================================================
ERROR: Tests that kernel getpass accept the stream parameter
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ipython/ipykernel/ipykernel/inprocess/tests/test_kernel.py", line 74, in test_getpass_stream
    kernel.getpass(stream='non empty')
  File "/home/travis/build/ipython/ipykernel/ipykernel/kernelbase.py", line 668, in getpass
    "getpass was called, but this frontend does not support input requests."
IPython.core.error.StdinNotImplementedError: getpass was called, but this frontend does not support input requests.

@Carreau Carreau force-pushed the add-stream-parameter-to-getpass branch from 241b2e8 to 4be0a55 Compare November 3, 2016 17:00
@Carreau
Copy link
Member Author

Carreau commented Nov 3, 2016

Travis should be happy. GitHub show the commits in the wrong order.

@takluyver takluyver merged commit 5b716cc into ipython:master Nov 3, 2016
@Carreau Carreau deleted the add-stream-parameter-to-getpass branch November 4, 2016 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants