use ctx.term to flush pipe messages #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracker method doesn't appear to be reliable for small messages this means creating/destroying new context/socket for each subprocess message, which is inefficient, but shouldn't be too costly
Member
Author
|
@takluyver this should fix the Jenkins builds |
Member
|
You mean, the hanging issue as well as the intermittent number-of-hellos failure? |
takluyver
added a commit
that referenced
this pull request
Feb 12, 2016
use ctx.term to flush pipe messages
Member
|
Does not appear to have fixed the hanging issue - that was pure optimism on my part! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracker method doesn't appear to be reliable for small messages, since zmq does some optimizations to always copy small messages.
This means creating/destroying new context/socket for each subprocess message, which is inefficient but shouldn't be too costly.
I've run the tests with this on Jenkins with the same env that was failing previously. Prior to this patch, the failure occurred pretty consistently around 10% of the time. It's now passed 50 times and counting without failure, so the fix seems to be successful.
closes #98 (hopefully)