fix for deduperreload global env in case of function decorator from imported module#14922
Merged
krassowski merged 1 commit intoipython:mainfrom Jun 27, 2025
Conversation
Contributor
Author
|
FYI @jaysarva |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
In deduperreload, if the function we're patching is decorated by a function coming from another file, we don't want to use the
__globals__of that function coming from the other file when we exec code, since it won't have the same references as the function we're trying to patch. Actually, I think we always should be using the module's__dict__as globals regardless for this case -- so I think we can just delete some code that was trying to be clever around setting the global env.How is this tested?
Tested with existing unit tests + added a new one that only passes with the new changes in this PR