Conversation
|
This isn't going to work with JLab while JLab is using phosphor 0.7 - we'll have conflicting versions of phosphor, and thus it breaks compiling the widget plugin for phosphor. So I'm bumping this to 6.1, with the idea that we can merge this after Jupyter moves to Phosphor 1.0. |
|
Actually, maybe this just might work. If I leave jupyterlab_widgets with phosphor 0.7.0, but I do upgrade typescript there to 2.1.0 (so I can compile against jupyter-js-widgets), I get just one error: |
4afc0f9 to
35b6760
Compare
|
By avoiding the type-checking right at the interface of the old and new phosphor (by setting the OutputWidget output area to have type any), we can get this to compile. It even sort of works @sccolbert, @blink1073 - do you see any huge problems with mixing phosphor pre-1.0 with JLab at this point? |
|
(The tabs and accordion widgets don't work in either the classic notebook or Lab - I'll look into this more...) |
|
The only problems you'll be likely to have are widgets which cross the boundaries of the modules. So dragdrop widgets between modules wont work. But you'll probably be "okay" other than that. |
|
Thanks. @SylvainCorlay - let's definitely tackle this after 6.0. It's subtle enough that I don't think we should try to push it in at this point. |
|
The output area itself is what it used as the drop value, so it should work fine. |
Things compile now.
Change tabsMovable setting to the user.
This compiles. I’m not sure if it works.
885eed8 to
c4f56e3
Compare
|
@SylvainCorlay - any comments on this before I merge it? |
Phosphor is coming up on a 1.0 release - this migrates our code to the pre-1.0 release.