explain which singleton is already instanciated#398
Merged
minrk merged 1 commit intoipython:masterfrom May 3, 2017
Merged
Conversation
ankostis
changed the title
minrk
changed the title
Carreau
added
5.0-re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the message when signleton instanciation fails because configurables already exist, by printing which is the offending class. Without this PR, in case there are many subclass candidates for a singleton, you need a debugger to identify which one has been instantiated on run-time.
This is the new error message:
instead of just: