Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new "Alter the Future NOW" card that can be played at any time, enhancing the game's strategic possibilities. The card is an upgraded version of the existing "Alter the Future" card with immediate play capability.
- Introduces "alter_future_now" card with "now" property allowing anytime play
- Updates game logic to support cards playable outside of turn order
- Modifies UI to distinguish between turn-based and immediate card actions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/recipes.json | Adds alter_future_now card to game recipes and updates recipe names |
| resources/cards.json | Defines the new alter_future_now card with NOW ability |
| eggsplode/ui/play.py | Updates UI logic to handle cards playable anytime vs turn-based cards |
| eggsplode/core.py | Implements action_player_id concept to track who initiated an action |
| eggsplode/cards/future.py | Refactors alter future UI component and fixes card selection logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #100