Guard against NPE in BagGenerator#12246
Merged
stevenwinship merged 2 commits intoIQSS:developfrom Mar 27, 2026
Merged
Conversation
scolapasta
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
qqmyers
approved these changes
Mar 25, 2026
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Looks good. It's a small change but could have a release note.
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
Author
|
Contributor
|
Reproduced bug in develop branch. Verified new fix works. Will merge once the develop branch code freeze ends. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
jp-tosca
pushed a commit
that referenced
this pull request
Mar 30, 2026
* Guard against NPE * Release note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When there are more than one contacts, it may occur that one of them does not have a "name" sub-field. In that case
contactNameTermis notnull, but((JsonObject) person).get(contactNameTerm.getLabel())does evaluate tonull, causing an NPE.Which issue(s) this PR closes:
N/a
Special notes for your reviewer:
None
Suggestions on how to test this:
Before fix, the archiving will fail.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
See: https://github.com/IQSS/dataverse/pull/12246/changes#diff-3dd3cb83d7219250c6bfbacb2f7d829b806a67e46020967f63ab039b5e506d3f
Additional documentation:
N/a