Skip to content

Revert "BugFix: controlled vocab values validation"#12342

Merged
stevenwinship merged 1 commit intodevelopfrom
revert-11950-11900-improved-cvoc-value-validation
Apr 20, 2026
Merged

Revert "BugFix: controlled vocab values validation"#12342
stevenwinship merged 1 commit intodevelopfrom
revert-11950-11900-improved-cvoc-value-validation

Conversation

@landreev
Copy link
Copy Markdown
Contributor

@landreev landreev commented Apr 20, 2026

Reverts #11950

We have to revert the PR, since it broke OAI harvesting when using oai_dc format (which happens to be the most popular OAI format).
It also broke the following 5 tests:

edu.harvard.iq.dataverse.api.HarvestingClientsIT.testHarvestingClientRun_AllowHarvestingMissingCVV_True_WithSourceName
edu.harvard.iq.dataverse.api.HarvestingClientsIT.testHarvestingClientRun_AllowHarvestingMissingCVV_True
edu.harvard.iq.dataverse.api.HarvestingClientsIT.testHarvestingFromDatacite
edu.harvard.iq.dataverse.api.HarvestingClientsIT.testHarvestingClientRun_AllowHarvestingMissingCVV_False
edu.harvard.iq.dataverse.api.SearchIT.testDataverseDatasetCounts

... however, for some strange reason Jenkins tests were not run on this PR since https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/view/change-requests/job/PR-11950/9/ (i.e., since November, where it passed), and that must be the reason why this was not detected before the PR was merged.

[edit: and that must be the reason why this was not detected before the PR was merged - actually, I'm not 100% about this; vs some scenario where there were in fact more Jenkins runs, but they somehow got deleted - ? Doesn't matter at this point, really]

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 24.873% (-0.001%) from 24.874% — revert-11950-11900-improved-cvoc-value-validation into develop

@stevenwinship stevenwinship merged commit 7054b64 into develop Apr 20, 2026
20 checks passed
@github-actions
Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:revert-11950-11900-improved-cvoc-value-validation
ghcr.io/gdcc/configbaker:revert-11950-11900-improved-cvoc-value-validation

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@landreev landreev deleted the revert-11950-11900-improved-cvoc-value-validation branch April 20, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants