8063 Tworavens Example Manifest Update, Disclaimer#8083
Merged
Conversation
djbrooke
changed the title
pdurbin
reviewed
Sep 1, 2021
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't test it but I don't think the change from type to types will work as written.
Otherwise, it seems fine but someday I still think we should stop hosting this manifest file for TwoRavens. I know they're grandfathered in.
pdurbin
approved these changes
Sep 1, 2021
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't test this, but it should work. I'm glad for the note to contact the TwoRavens team as necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In #8063 it was suggested we update the TwoRavens manifest so that it still works with our recent changes to external tools. @pdurbin noted that we should rely on the external developers to maintain these manifests, so along with the update I added a disclaimer and pointed people to the TwoRavens team for support. If this breaks again, we can consider taking more extensive action.
Which issue(s) this PR closes:
Closes #8063
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: