Large file upload - internationalization of error message#8614
Merged
kcondon merged 4 commits intoIQSS:developfrom May 10, 2022
Merged
Conversation
JayanthyChengan
changed the title
…internationalization # Conflicts: # src/main/webapp/themeAndWidgetsFragment.xhtml
…internationalization
sekmiller
reviewed
May 10, 2022
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
@JayanthyChengan the coding for the messaging looks good. I'm just wondering about the updates to the old scripts. I think they will only be effective for upgrades to versions prior to the numbers on the scripts ( 4.13 and 4.16).
Contributor
Author
|
@sekmiller - that was my mistake, reverted them back |
Contributor
|
@JayanthyChengan, Thanks! I will pass along to QA. |
sekmiller
approved these changes
May 10, 2022
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The internationalization of "Invalid file size" message is implemented, when a user uploads a large image file on the Themes and Widgets page.
Which issue(s) this PR closes:
Closes #8593
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: