Minor improvements for the external metadata filtering#9730
Merged
Conversation
This may be all that needs to be added to 5.14 to accommodate #9727.
pdurbin
approved these changes
Jul 24, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't test this but the changes make sense
Contributor
Author
|
Added the milestone 5.14, per #9727. |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a couple of extra bits of information to the json that the application passes to the external metadata filter. This is for better record keeping and managing white lists on the filter side.
Which issue(s) this PR closes:
Closes #9727
Special notes for your reviewer:
Suggestions on how to test this:
All this PR does is add 2 extra fields to the json exports for datasets and collections that are generated for the external filter.
The easiest way to test would be to configure the filtering by setting both
:DataverseMetadataValidatorScriptand:DatasetMetadataValidatorScriptto/usr/bin/true; then publish a collection and a dataset, and inspect the metadata exports left in/tmp. Both should have the 2 extra fields at the end:userIdentifierandparentAlias.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: