Skip to content

Move describe method from EjbDataverseEngine to Command interface #4262

@scolapasta

Description

@scolapasta

Our current design has an actionlog that tracks (among other things) every command called. One of the fields in details which is populated from the describe method in the EjbDataverseEngine. While this is useful, this describe method is composed generically for all commands.

Going forward, we would like to move the describe method to the Command interface so that we can maintain the generic approach for most commands, but also override in any specific Command.

A specific example is AssignRoleCommand. When you assign a role the describe command (generically) puts in the affected object id and name, however when assigning a rpole to a file, it puts in the dataset name, since the permission check for assigning a role for a file is checked at the dataset (i.e. it is the "affected object). Allowing override of the description would allow this command to specify the file, instead of the dataset.

For this issue, we'd like to provide the infrastructure to support this (the moving of describe) and the specific example of overriding in one class (so let's go with AssignRole as this will be immediately useful).

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions