fix: handle taxa count divisible by 32 #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following snippet crashes under
-fsanitize=undefinedwhen the number of taxa is a multiple of 32.iqtree3/pda/split.cpp
Lines 179 to 185 in 7cded0c
The fix simply sets
num_bitsto 32 in that case. It's similar to the fix in iqtree/iqtree2#412. I also manually checked all relevant parts in this file using the same logic.I think we also need to backport this fix to IQ-TREE 2.