Add a dedicated pass to partition gathers/scatters #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcode84
force-pushed
the
partititon-gathers
branch
2 times, most recently
from
ab400b1 to
42a5386
Compare
Hardcode84
changed the title
Hardcode84
force-pushed
the
partititon-gathers
branch
2 times, most recently
from
814686b to
f63235c
Compare
harsh-nod
requested changes
Sep 10, 2025
Collaborator
harsh-nod
left a comment
harsh-nod
left a comment
There was a problem hiding this comment.
this should be a nice cleanup. thanks!
| elements_per_thread=1, | ||
| ).add_to_graph(custom.graph) | ||
| elif isinstance(custom, Read): | ||
| # TODO: Add support on how to handle strided reads. |
Collaborator
There was a problem hiding this comment.
Why won't the existing code handle strided reads? And what about strides writes?
Contributor
Author
There was a problem hiding this comment.
this was a stale comment, removed
Hardcode84
force-pushed
the
partititon-gathers
branch
from
f63235c to
da329a3
Compare
harsh-nod
approved these changes
Sep 16, 2025
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Hardcode84
force-pushed
the
partititon-gathers
branch
from
da329a3 to
daceb1a
Compare
Megan0704-1
pushed a commit
to Megan0704-1/wave
that referenced
this pull request
Oct 28, 2025
Move gather/scatter decomposition into dedicated pass. This allows to cleanup a lot of code in read/write handlers and get rid of last traces of `vector.gather`/`scatter` there. --------- Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move gather/scatter decomposition into dedicated pass. This allows to cleanup a lot of code in read/write handlers and get rid of last traces of
vector.gather/scatterthere.