Skip to content

Conversation

@Megan0704-1
Copy link
Contributor

Supersedes #287. We'll use this PR to track progress of RDNA MMA type support.
Thanks @paulzzy for the early exploration.

@Megan0704-1 Megan0704-1 force-pushed the wave/megan.kuo/wmma_wave32_f32_16x16x16_f16 branch 2 times, most recently from fd99332 to 4d6b402 Compare September 25, 2025 23:07
@Megan0704-1
Copy link
Contributor Author

Note: K-dimension offset deviates from the ISA.
Rationale: The ISA-prescribed pattern (K = 8 * floor(GPR_NUM / 4) + 4 * floor(lane / 16) + (GPR_NUM % 4)) forces extra re-layout work between chained GEMMs.
Because reduction over K is associative, we relax the ISA constraint for the K layout to avoid those transforms while preserving ISA-conformant M/N indexing.

@Megan0704-1 Megan0704-1 marked this pull request as ready for review September 25, 2025 23:13
@Megan0704-1 Megan0704-1 force-pushed the wave/megan.kuo/wmma_wave32_f32_16x16x16_f16 branch from 097aa53 to dfe5885 Compare September 26, 2025 23:45
Signed-off-by: megan.kuo <mkuo@amd.com>
Signed-off-by: megan.kuo <mkuo@amd.com>
Signed-off-by: megan.kuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
…matrix for RDNA is aligned, we don't really care about how lane is indexing the reduction dimension for its associative nature

Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
@Megan0704-1 Megan0704-1 force-pushed the wave/megan.kuo/wmma_wave32_f32_16x16x16_f16 branch from 5c11bca to 233a5f7 Compare September 30, 2025 16:19
Copy link
Contributor

@Hardcode84 Hardcode84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Megan0704-1
Copy link
Contributor Author

Thanks for the review @Hardcode84. When you have a moment, could you help merge this into main please?

@Hardcode84 Hardcode84 merged commit 3e92c50 into iree-org:main Oct 1, 2025
19 checks passed
saladpalad pushed a commit to saladpalad/wave that referenced this pull request Oct 3, 2025
Supersedes iree-org#287. We'll use this PR to track progress of RDNA MMA type
support.
Thanks @paulzzy for the early exploration.

---------

Signed-off-by: megan.kuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Megan0704-1 added a commit to Megan0704-1/wave that referenced this pull request Oct 28, 2025
Supersedes iree-org#287. We'll use this PR to track progress of RDNA MMA type
support.
Thanks @paulzzy for the early exploration.

---------

Signed-off-by: megan.kuo <mkuo@amd.com>
Signed-off-by: mkuo <mkuo@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants