Forward codegen info for read/write to wave attributes #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb0807
requested review from
adedespirlet,
ftynse,
martin-luecke and
tgymnich
ftynse
approved these changes
Oct 11, 2025
Contributor
ftynse
left a comment
ftynse
left a comment
There was a problem hiding this comment.
LGTM, but please give @martin-luecke a chance to review
| op.attributes["index"] = ir.DictAttr.get(index_mappings) | ||
|
|
||
| if getattr(node, "elements_per_thread", None): | ||
| op.attributes["wave.elements_per_thread"] = ir.IntegerAttr.get( |
Contributor
There was a problem hiding this comment.
Can we avoid using generic syntax? Probably not in this commit and may require thinking about exposing something like interfaces in python...
martin-luecke
approved these changes
Oct 13, 2025
Contributor
martin-luecke
left a comment
martin-luecke
left a comment
There was a problem hiding this comment.
LGTM, let's just see that CI successfully runs the mlir_converter.py lit test on linux-mi325-1gpu-ossci-iree-org before merging
tyb0807
force-pushed
the
wave_attr
branch
5 times, most recently
from
8fb19cd to
3bbac5f
Compare
Signed-off-by: tyb0807 <sontuan.vu@amd.com>
Signed-off-by: tyb0807 <sontuan.vu@amd.com>
Signed-off-by: tyb0807 <sontuan.vu@amd.com>
Signed-off-by: tyb0807 <sontuan.vu@amd.com>
Megan0704-1
pushed a commit
to Megan0704-1/wave
that referenced
this pull request
Oct 28, 2025
Signed-off-by: tyb0807 <sontuan.vu@amd.com>
suryajasper
pushed a commit
to suryajasper/wave
that referenced
this pull request
Oct 29, 2025
Signed-off-by: tyb0807 <sontuan.vu@amd.com> Signed-off-by: Surya Jasper <45545431+suryajasper@users.noreply.github.com>
adedespirlet
pushed a commit
to adedespirlet/wave
that referenced
this pull request
Oct 29, 2025
Signed-off-by: tyb0807 <sontuan.vu@amd.com>
sa-faizal
pushed a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: tyb0807 <sontuan.vu@amd.com> Signed-off-by: sa-faizal <sahil.faizal@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.