Fix gather-to-lds tail padding calculations #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a tail padding calculation bug in the gather-to-shared operation. When the total number of elements is perfectly divisible by elements_per_wave, the tail padding should be 0, not elements_per_wave.
Key changes:
- Fixed tail_padding calculation to correctly handle the case when materialized shape is perfectly divisible by elements_per_wave
- Updated test expectations to reflect changes in memory allocation patterns (direct allocation instead of view-based allocation)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wave_lang/kernel/wave/gather_to_shared.py | Fixed tail_padding calculation by adding modulo operation to avoid unnecessary padding when perfectly divisible |
| lit_tests/kernel/wave/gather_to_shared.py | Updated test expectations to match new memory allocation patterns (direct alloc instead of alloc+view) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raikonenfnu
reviewed
Oct 29, 2025
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raikonenfnu
approved these changes
Oct 29, 2025
sa-faizal
pushed a commit
that referenced
this pull request
Nov 3, 2025
Padding should 0 when sizes are aligned. --------- Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com> Signed-off-by: sa-faizal <sahil.faizal@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding should 0 when sizes are aligned.