[Compiler][Gemm] Optimize memory waitcnt for Async BF16 PP GEMM #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raikonenfnu
commented
Nov 10, 2025
raikonenfnu
commented
- Implemented memory_counter_wait op
- Use memory_counter_wait op to optimize waitcnt in async BF16 PP GEMM
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
Hardcode84
reviewed
Nov 10, 2025
harsh-nod
reviewed
Nov 10, 2025
harsh-nod
approved these changes
Nov 10, 2025
Collaborator
harsh-nod
left a comment
harsh-nod
left a comment
There was a problem hiding this comment.
LGTM! just a minor refactor comment
raikonenfnu
force-pushed
the
raikonenfnu/waitcnt
branch
from
58e092c to
28d0b28
Compare
Hardcode84
approved these changes
Nov 10, 2025
Contributor
Hardcode84
left a comment
Hardcode84
left a comment
There was a problem hiding this comment.
We probably need to update amdgpu.memory_counter_wait upstream to support tensorcnt too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.