[WAVE] Merge two kernels into one in wave speculative decode #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xintin
commented
Jul 22, 2025
xintin
commented
- merged two kernels into one kernel
- updated lit test
harsh-nod
requested changes
Jul 23, 2025
Collaborator
harsh-nod
left a comment
harsh-nod
left a comment
There was a problem hiding this comment.
Overall, looks good, there are just a couple of questions about the changes.
Signed-off-by: xintin <gaurav.verma@amd.com>
Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
force-pushed
the
merge_two_kernels_into_one_spec_decode
branch
from
aeef134 to
9f224b2
Compare
harsh-nod
reviewed
Jul 23, 2025
harsh-nod
approved these changes
Jul 23, 2025
Collaborator
harsh-nod
left a comment
harsh-nod
left a comment
There was a problem hiding this comment.
Please land after addressing comments.
Signed-off-by: xintin <gaurav.verma@amd.com>
badgerbroch
pushed a commit
to badgerbroch/wave
that referenced
this pull request
Jul 29, 2025
…g#75) - merged two kernels into one kernel - updated lit test --------- Signed-off-by: xintin <gaurav.verma@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.