[water] enforce uniqueness of symbolic tensor dimensions #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbols indicate how dimensions are indexed. Repeating the symbol means we would be indexing two dimensions identically, i.e., their indexes are always equal, which is not desirable. Signed-off-by: Alex Zinenko <git@ozinenko.com>
tgymnich
approved these changes
Jan 26, 2026
martin-luecke
approved these changes
Jan 28, 2026
Contributor
martin-luecke
left a comment
martin-luecke
left a comment
There was a problem hiding this comment.
LGTM, but let's also document this constraint on WaveTensorType in WaveTypes.td
Signed-off-by: Alex Zinenko <git@ozinenko.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbols indicate how dimensions are indexed. Repeating the symbol means we
would be indexing two dimensions identically, i.e., their indexes are always
equal, which is not desirable.
Signed-off-by: Alex Zinenko git@ozinenko.com