Skip to content

Build REST API endpoints (POST, DELETE) for Tasks#4

Merged
irfiacre merged 3 commits intodevelopfrom
ft-create-tasks
Mar 11, 2020
Merged

Build REST API endpoints (POST, DELETE) for Tasks#4
irfiacre merged 3 commits intodevelopfrom
ft-create-tasks

Conversation

@fordarnold
Copy link
Copy Markdown
Collaborator

What does this PR do?

The PR implements logic for creating and deleting a task in the database.

Description of Task to be completed?

We've used the Node/Express router to setup REST API endpoints to POST and DELETE tasks in the app database.

How should this be manually tested?

  • Send a POST request to /api/v1/tasks (including properties of a Task in the request body)
  • Send a DELETE request to /api/v1/tasks/{id}

@fordarnold fordarnold added the enhancement New feature or request label Mar 10, 2020
@fordarnold fordarnold requested a review from irfiacre March 10, 2020 21:41
@fordarnold fordarnold self-assigned this Mar 10, 2020
@kabundege
Copy link
Copy Markdown
Collaborator

@fordarnold keep in mind that a pr should have one commit message before merging it.
Currently, this pr has 9 commits be sure to check it out.

@fordarnold
Copy link
Copy Markdown
Collaborator Author

@fordarnold keep in mind that a pr should have one commit message before merging it.
Currently, this pr has 9 commits be sure to check it out.

@kabundege, as we were told by LF yesterday, I believe this one is the job of the Team Lead @irfiacre ... He needs to use "Git Squash and Merge" option when he is merging my PR into develop.

That option will allow him to write a single commit message for the merge.

@kabundege
Copy link
Copy Markdown
Collaborator

@fordarnold keep in mind that a pr should have one commit message before merging it.
Currently, this pr has 9 commits be sure to check it out.

@kabundege, as we were told by LF yesterday, I believe this one is the job of the Team Lead @irfiacre ... He needs to use "Git Squash and Merge" option when he is merging my PR into develop.

That option will allow him to write a single commit message for the merge.

@kabundege kabundege closed this Mar 11, 2020
@kabundege kabundege reopened this Mar 11, 2020
I made these changes when trying to fix failing tests in Travis.
@irfiacre irfiacre merged commit d44549c into develop Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants