Conversation
xchourio
approved these changes
Mar 31, 2025
aaron-kaplan
reviewed
Apr 2, 2025
aaron-kaplan
approved these changes
Apr 2, 2025
This was referenced Apr 9, 2025
remicousin
force-pushed
the
splitshpandmapping
branch
from
1a5171f to
b9f83f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bunch of factorization for us to get ready to split shapes reading from apps and apply the case of fake shapes. But I am not sure at what level we'll fork the fake case... at sql/db? at GeoJSON? create dummy geom from scratch?
The commits kind of make sense in chronological order except I forgot to add the new file which should have been in the 2nd commit, and later commits update the former so... might make more sense to look at the final thing. Commits' comments tell you the story.