WIP pretty printing support #3
Open
+276
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irionr
reviewed
Nov 7, 2025
Comment on lines
+97
to
+100
| #define GET_DDL_PRETTY_FLAGS(pretty) \ | ||
| ((pretty) ? (PRETTYFLAG_PAREN | PRETTYFLAG_INDENT | PRETTYFLAG_SCHEMA) \ | ||
| : 0) | ||
|
|
Owner
There was a problem hiding this comment.
Suggested change
| #define GET_DDL_PRETTY_FLAGS(pretty) \ | |
| ((pretty) ? (PRETTYFLAG_PAREN | PRETTYFLAG_INDENT | PRETTYFLAG_SCHEMA) \ | |
| : 0) |
Owner
There was a problem hiding this comment.
I don't like adding the GET_DDL_PRETTY_FLAGS, but maybe it's just me. If you have a strong feeling, let it be as it is
Comment on lines
+13921
to
+13925
| bool pretty = PG_GETARG_BOOL(1); | ||
| char *res; | ||
| int prettyFlags; | ||
|
|
||
| prettyFlags = GET_DDL_PRETTY_FLAGS(pretty); |
Owner
There was a problem hiding this comment.
Suggested change
| bool pretty = PG_GETARG_BOOL(1); | |
| char *res; | |
| int prettyFlags; | |
| prettyFlags = GET_DDL_PRETTY_FLAGS(pretty); | |
| bool pretty; | |
| char *res; | |
| int prettyFlags = true; | |
| if (PG_ARGISNULL(1)) | |
| pretty = PG_GETARG_BOOL(1); | |
| prettyFlags = pretty ? PRETTYFLAG_INDENT : 0; |
Owner
There was a problem hiding this comment.
I propose this, instead of the GET_DDL_PRETTY_FLAGS, but it's your choice.
Comment on lines
+660
to
+664
| CREATE OR REPLACE FUNCTION | ||
| pg_get_domain_ddl(domain_name regtype, pretty bool DEFAULT false) | ||
| RETURNS text | ||
| LANGUAGE internal | ||
| AS 'pg_get_domain_ddl_ext'; |
Owner
There was a problem hiding this comment.
Why do we need this?
Isn't it better to have it in pg_proc.dat, also the one with a one-argument signature?
| { oid => '8024', descr => 'get CREATE statement for DOMAIN with pretty option', | ||
| proname => 'pg_get_domain_ddl', prorettype => 'text', | ||
| proargtypes => 'regtype', prosrc => 'pg_get_domain_ddl' }, | ||
| proargtypes => 'regtype bool', prosrc => 'pg_get_domain_ddl_ext' }, |
Owner
There was a problem hiding this comment.
Suggested change
| proargtypes => 'regtype bool', prosrc => 'pg_get_domain_ddl_ext' }, | |
| proargtypes => 'regtype bool', prosrc => 'pg_get_domain_ddl_ext' }, | |
| { oid => '8025', descr => 'get CREATE statement for DOMAIN', | |
| proname => 'pg_get_domain_ddl', prorettype => 'text', | |
| proargtypes => 'regtype', prosrc => 'pg_get_domain_ddl_ext' }, |
Owner
There was a problem hiding this comment.
this instead of adding the create function, better to have all teh changes in one place, maybe...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.