Fix replies to use correct NIP-10 tags #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyiu
commented
Mar 28, 2025
Comment on lines
-210
to
-218
| if (repliedEvent) { | ||
| event.tags = [ | ||
| ["p", repliedEvent.pubkey], | ||
| ["e", repliedEvent.id, "", "reply", repliedEvent.pubkey], | ||
| ] | ||
| } | ||
| if (quotedEvent) { | ||
| event.tags.push(["e", quotedEvent.id, "", "mention", quotedEvent.pubkey]) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Redundant because the add tags function was already doing all of this. Not sure why it's needed again.
tyiu
commented
Mar 28, 2025
| } | ||
|
|
||
| function addPTags(event: NDKEvent, repliedEvent?: NDKEvent, quotedEvent?: NDKEvent) { | ||
| function addTags(event: NDKEvent, repliedEvent?: NDKEvent, quotedEvent?: NDKEvent) { |
Contributor
Author
There was a problem hiding this comment.
Renamed addPTags to addTags because it was doing more than just adding p-tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIP-10 - Text Notes and Threads
Closes: nostrability/nostrability#174
This bug was causing replies to hellthreads to leak through thread muting preferences on most clients, even if the root was muted.
Example event from @alltheseas that demonstrates the bug when posting from Iris (notice that there is a
replymarker where there should actually be both arootandreplymarker):https://iris.to/nevent1qgsxtefrkzdwcyn03g26k3u5vvht5xmm0g5kyp2kajwyu27rk8qdgugpz4mhxue69uhhxarjvee8jtnfwf5hxtn5duhsz9thwden5te0wd68yenj0yhxjunfwvh8gme0qqsdvy3tpv8urd7xz8d9sg5hx28ju8dh93tg0mcpjsledgnps7dltmgt7j94t
Here's some notes that I posted from running this bug fix locally in development that demonstrates the fix working:
Direct reply (has only a root marker): https://iris.to/nevent1qgswjsh886kl767cxkt8h9xfm4cm3xez9zqu6dv6gs6erj8dvymqtzspz4mhxue69uhhxarjvee8jtnfwf5hxtn5duhsz9thwden5te0wfjkccte9ejxzmt4wvhxjme0qqsxr8957h3w28tmdyd9n9h8fvndmwk78mjzwd5r2xz7gdklggy9dmgf32qxr
Reply of a reply (has root and reply markers): https://iris.to/nevent1qgswjsh886kl767cxkt8h9xfm4cm3xez9zqu6dv6gs6erj8dvymqtzspz4mhxue69uhhxarjvee8jtnfwf5hxtn5duhsz9thwden5te0wd68yenj0yhxjunfwvh8gme0qqsfxsj43e58fdfypvalzlj08tdy9t5hzw6n3hkhqgr05lmwkzdm7kqwl9c8v
Hellthread reply (has root and reply markers, and carries over all the p-tags): https://iris.to/nevent1qgswjsh886kl767cxkt8h9xfm4cm3xez9zqu6dv6gs6erj8dvymqtzspz4mhxue69uhhxarjvee8jtnfwf5hxtn5duhsz9thwden5te0wfjkccte9ejxzmt4wvhxjme0qqsd2w3rjmp7w54uwr5ze68ejlh2h9xq35ll83pjzq40x9pmvskhlkq5sczle
Behavior for mentions did not change, proof: https://iris.to/nevent1qgswjsh886kl767cxkt8h9xfm4cm3xez9zqu6dv6gs6erj8dvymqtzspz4mhxue69uhhxarjvee8jtnfwf5hxtn5duhsz9thwden5te0wd68yenj0yhxjunfwvh8gme0qqsf9qfttttuhmf6p5ac5mtrshpfaclrhygum9wrzdfu9rxra66rqccpvswqc