Skip to content

Iron 386 replace all system drawing with iron drawing#24

Merged
mee-ironsoftware merged 21 commits intomasterfrom
IRON-386-replace-all-system-drawing-with-iron-drawing
Dec 28, 2022
Merged

Iron 386 replace all system drawing with iron drawing#24
mee-ironsoftware merged 21 commits intomasterfrom
IRON-386-replace-all-system-drawing-with-iron-drawing

Conversation

@mee-ironsoftware
Copy link
Copy Markdown
Member

Features Added

AnyBitmap

  • Scan0 to gets the address of the first pixel data of the AnyBitmap object
  • Stride to gets the stride width (also called scan width) of the AnyBitmap object
    MimeType to gets MIMEType of the AnyBitmap object including image/bmp, image/jpeg, image/png, image/gif, image/tiff, image/webp, and image/unknown
  • GetImageFormat to gets ImageFormat of the AnyBitmap object
  • HorizontalResolution, and VerticalResolution to gets the resolution of the image in x, y direction

Color

  • Add override FromArgb(alpha, BaseColor)
  • Add compare Color including ==, !=, and Equals
  • Create Color from name

Bug Fixed

AnyBitmap

  • Fixed loss transparency when convert System.Drawing.Bitmap to AnyBitmap
  • Fixed loss transparency when convert System.Drawing.Image to AnyBitmap
  • Fixed loss transparency when convert SixLabors.ImageSharp.Image to AnyBitmap

- Get Color from name by KnownColors
- Modify Color XML comment
- Install libgdiplus
- Add .NET70 UT to MacOS
- For MacOS will run in sequence
- Remove install Dotnet in each UT run
- operator ==
- operator !=
- Equals
- Fixed incorrect image color when read Tiff
- Fixed loss transparency when convert from ImageSharp to AnyBitmap
- Fixed System.Drawing to AnyBitmap loss transparency
- Add new function Stride, Scan0, and MimeType
- Add function GetImageFormat()
Still System.Drawing.Common v5.0.3
- Also add unit tests for Scan0, and Stride
- Also add missing XML Comment
Comment thread IronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs Outdated
Comment thread NuGet/IronSoftware.Drawing.nuspec Outdated
Comment thread IronSoftware.Drawing/IronSoftware.Drawing.Common/KnownColors.cs
Comment thread IronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs Outdated
Comment thread IronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs Outdated
Copy link
Copy Markdown
Contributor

@mbkrispy mbkrispy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@mee-ironsoftware mee-ironsoftware force-pushed the IRON-386-replace-all-system-drawing-with-iron-drawing branch 6 times, most recently from c13a70b to e1b16d9 Compare December 26, 2022 04:15
@mee-ironsoftware mee-ironsoftware force-pushed the IRON-386-replace-all-system-drawing-with-iron-drawing branch 8 times, most recently from 1993a12 to c7393fd Compare December 26, 2022 06:18
@mee-ironsoftware mee-ironsoftware force-pushed the IRON-386-replace-all-system-drawing-with-iron-drawing branch 4 times, most recently from 857d953 to 9ffb94e Compare December 27, 2022 03:30
- Remove deps file on netstandard2.0
- Modify releasenotes
@mee-ironsoftware mee-ironsoftware force-pushed the IRON-386-replace-all-system-drawing-with-iron-drawing branch from 9ffb94e to bf6f30b Compare December 27, 2022 03:39
djrecipe and others added 2 commits December 28, 2022 09:43
adds nuget dependency to System.Memory v4.5.5 for net462
…nflict

adds nuget dependency to System.Memory v4.5.5 for net462
@jacob-mellor
Copy link
Copy Markdown
Member

jacob-mellor commented Dec 28, 2022

This PR looks good to me

Are there any specific files or parts you wish me to look over or review in more detail?

@mee-ironsoftware

Comment thread IronSoftware.Drawing/IronSoftware.Drawing.Common/AnyBitmap.cs Outdated
@mee-ironsoftware mee-ironsoftware merged commit d51a711 into master Dec 28, 2022
@artem-iron artem-iron deleted the IRON-386-replace-all-system-drawing-with-iron-drawing branch March 28, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants