Skip to content

Fixes Assembly version#75

Merged
mee-ironsoftware merged 5 commits intomasterfrom
fix-assembly-version
Sep 20, 2023
Merged

Fixes Assembly version#75
mee-ironsoftware merged 5 commits intomasterfrom
fix-assembly-version

Conversation

@mee-ironsoftware
Copy link
Copy Markdown
Member

@mee-ironsoftware mee-ironsoftware commented Sep 20, 2023

Description

The revision version of assembly version should be between minor and patch instead of last digit.
Ex. NuGet Version is 2023.10.1, Assembly Version should be 2023.10.0.1

Type of change

Please select the relevant option by placing an 'x' inside the brackets, like this: [x].

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Internal/structural update (non-breaking change that improves code quality, organization, or performance)
  • 📚 This change requires a documentation update
  • 🚀 DevOps build chain modification for release
  • 🤖 DevOps build chain modification for CI

How Has This Been Tested?

Run pipeline and check assembly version. Please check here.

Checklist:

Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully run all unit tests on Windows
  • I have successfully run all unit tests on Linux

@mee-ironsoftware mee-ironsoftware force-pushed the fix-assembly-version branch 4 times, most recently from 4ae3e2c to dc4c467 Compare September 20, 2023 03:39
Copy link
Copy Markdown
Contributor

@mbkrispy mbkrispy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

Copy link
Copy Markdown
Contributor

@artem-iron artem-iron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀🚀

Copy link
Copy Markdown
Contributor

@djrecipe djrecipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄🏼 send it!

@mee-ironsoftware mee-ironsoftware merged commit 8512caa into master Sep 20, 2023
@mbkrispy mbkrispy deleted the fix-assembly-version branch October 13, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants