Conversation
djrecipe
requested review from
artem-iron,
jacob-mellor and
mee-ironsoftware
and removed request for
artem-iron and
mee-ironsoftware
| /// Create a new Bitmap from a a Byte Span. | ||
| /// </summary> | ||
| /// <param name="span">A Byte Span of image data in any common format.</param> | ||
| public static AnyBitmap FromSpan(ReadOnlySpan<byte> span) |
Contributor
There was a problem hiding this comment.
I can say "Wow" every time I see the word Span<T> in managed code :D
Contributor
Author
|
added tiff improvements; removed detrimental |
add console app for easy perf testing
add support for ReadOnlySpan; use Image.DetectFormat(); reduce copying when resizing tiffs
| @@ -0,0 +1,12 @@ | |||
| // See https://aka.ms/new-console-template for more information | |||
Contributor
There was a problem hiding this comment.
Good that we have test!
Alternatively, I think we could get away by grabbing memory usage information from either GC or System.Diagnostics, and validate if it doesn't reach higher than what rough goal we set. Because I think having a separate console app, very less chance others will know or will test against it.
Contributor
|
This is related to #57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory Improvements
AnyBitmap.FromSpan()and newAnyBitmapconstructor both which takeReadOnlySpan<byte>Image.DetectFormat()to avoid trying to load Tiffs (saves some time and memory)Span is a bit slower but uses much less memory. It's optional.
ReadOnlySpan Gains
Tiff Gains
Type of change
Please select the relevant option by placing an 'x' inside the brackets, like this: [x].
How Has This Been Tested?
Locally, see above images
Checklist:
Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].